Rustup to rust-lang/rust#66878 #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
approved these changes
Dec 3, 2019
flip1995
reviewed
Dec 4, 2019
| @@ -46,7 +46,7 @@ pub const IO_WRITE: [&str; 3] = ["std", "io", "Write"]; | |||
| pub const ITERATOR: [&str; 5] = ["core", "iter", "traits", "iterator", "Iterator"]; | |||
| pub const LATE_CONTEXT: [&str; 4] = ["rustc", "lint", "context", "LateContext"]; | |||
| pub const LINKED_LIST: [&str; 4] = ["alloc", "collections", "linked_list", "LinkedList"]; | |||
| pub const LINT: [&str; 3] = ["rustc", "lint", "Lint"]; | |||
| pub const LINT: [&str; 3] = ["rustc_session", "lint", "Lint"]; | |||
There was a problem hiding this comment.
This path changed and so the declared lints weren't detected anymore.
flip1995
changed the title
|
@bors r+ |
|
📌 Commit 21bb9ab has been approved by |
bors
added a commit
that referenced
this pull request
Dec 4, 2019
Rustup to rust-lang/rust#66878 I need to sleep now, feel free to pick it up. The output of the `lint_without_lint_pass` test seems to disappear, I'm not sure why.. :/ changelog: none
|
@bors r+ |
|
📌 Commit 98e433d has been approved by |
bors
added a commit
that referenced
this pull request
Dec 4, 2019
Rustup to rust-lang/rust#66878 I need to sleep now, feel free to pick it up. The output of the `lint_without_lint_pass` test seems to disappear, I'm not sure why.. :/ changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to sleep now, feel free to pick it up.
The output of the
lint_without_lint_passtest seems to disappear, I'm not sure why.. :/changelog: none