-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustup to rust-lang/rust#68045 #5042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream change is here: rust-lang/rust#68145 |
JohnTitor
added
the
S-blocked
Status: marked as blocked ❌ on something else such as an RFC or other implementation work
label
Jan 12, 2020
phansch
approved these changes
Jan 12, 2020
@bors r+ |
📌 Commit 17e5517 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 13, 2020
Rustup to rust-lang/rust#68045 This is blocked because `rustc_lint::context` is not pub module and `CheckLintNameResult` is not marked as `pub use`. changelog: none
💔 Test failed - status-appveyor |
Let me take a look (and I've realized to forget formatting). |
JohnTitor
force-pushed
the
rustup-0112
branch
from
January 13, 2020 12:46
17e5517
to
c97f7fc
Compare
JohnTitor
force-pushed
the
rustup-0112
branch
from
January 13, 2020 12:56
c97f7fc
to
ce1c6b2
Compare
JohnTitor
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
and removed
S-blocked
Status: marked as blocked ❌ on something else such as an RFC or other implementation work
labels
Jan 13, 2020
Okay, I think it should be ready to go. |
@bors r+ thanks! |
📌 Commit ce1c6b2 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 13, 2020
Rustup to rust-lang/rust#68045 This is blocked because `rustc_lint::context` is not pub module and `CheckLintNameResult` is not marked as `pub use`. changelog: none
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked because
rustc_lint::context
is not pub module andCheckLintNameResult
is not marked aspub use
.changelog: none