Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_while_next lint #5067

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Conversation

JohnTitor
Copy link
Member

Fixes #4036

changelog: Add skip_while_next lint

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

clippy_lints/src/methods/mod.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

@bors delegate+

r=me if you want to split up the messages of other lints in a separate PR, instead of in this PR.

@bors
Copy link
Contributor

bors commented Jan 20, 2020

✌️ @JohnTitor can now approve this pull request

@JohnTitor
Copy link
Member Author

Ah sorry, "later" was a little vague. I intended to follow up on another PR. So let's
@bors r=flip1995

@bors
Copy link
Contributor

bors commented Jan 20, 2020

📌 Commit bec5b69 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jan 20, 2020

⌛ Testing commit bec5b69 with merge eca0d8e...

bors added a commit that referenced this pull request Jan 20, 2020
Add `skip_while_next` lint

Fixes #4036

changelog: Add `skip_while_next` lint
@bors
Copy link
Contributor

bors commented Jan 20, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing eca0d8e to master...

@bors bors merged commit bec5b69 into rust-lang:master Jan 20, 2020
@JohnTitor JohnTitor deleted the lint-skip-while-next branch January 20, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement Idea: the ilter_next should also cover skip_while().next()
3 participants