Split up match ui test
#5108
Split up match ui test
#5108
Conversation
| | ^^^^^ | ||
| = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) | ||
|
|
||
| error: aborting due to 7 previous errors |
There was a problem hiding this comment.
The new error count only adds up to 11, while the old one was 15. Did some errors get lost during the move?
There was a problem hiding this comment.
Some match_same_arms warnings are actually duplicated. For example, matches.rs:60 and matches.rs:68 are the same, later one is unnecessary. And I suppressed match_same_arms lint in match_wild_err_arm ui test since I feel they're already covered in match_same_arms ui tests.
There was a problem hiding this comment.
LGTM. There are 9 less errors as before. These 9 errors are missing, because they are allowed in the match_wild_error_arm.rs test. This file contains 8 match statements, each with the simplest case of the match_same_arms lint. These are only 8 match statements, because one of these statements was a duplicate before.
If @phansch hasn't any concerns anymore r=me.
|
@bors r=flip1995 |
|
📌 Commit 411317b has been approved by |
Split up `match` ui test Part of #2038 Also, this decreases the line length limit to 220. changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Part of #2038
Also, this decreases the line length limit to 220.
changelog: none