Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up indexing_slicing ui test #5130

Merged
merged 3 commits into from
Feb 3, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Feb 3, 2020

Closes #2038

Now all the stderrs are less than 200 lines 🎉

changelog: none

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 3, 2020
@flip1995
Copy link
Member

flip1995 commented Feb 3, 2020

I think #2038 can be closed with this. I don't think we should set a soft limit (or how we should enforce). cc @phansch

@flip1995
Copy link
Member

flip1995 commented Feb 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2020

📌 Commit 49934e7 has been approved by flip1995

bors added a commit that referenced this pull request Feb 3, 2020
Split up `indexing_slicing` ui test

Closes #2038

Now all the stderrs are less than 200 lines 🎉

changelog: none
@bors
Copy link
Contributor

bors commented Feb 3, 2020

⌛ Testing commit 49934e7 with merge 536c255...

@bors
Copy link
Contributor

bors commented Feb 3, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 536c255 to master...

@bors bors merged commit 49934e7 into rust-lang:master Feb 3, 2020
@JohnTitor JohnTitor deleted the split-up-index-slice branch February 3, 2020 18:08
@phansch
Copy link
Member

phansch commented Feb 4, 2020

Thanks a lot for pushing this through @JohnTitor 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Split up our UI-tests into smaller parts
4 participants