Move unneeded_field_pattern to restriction group #5200
Conversation
CHANGELOG.md
Outdated
| * Move `unneeded_field_pattern` to pedantic group [#1741](https://github.com/rust-lang/rust-clippy/issues/1741) | ||
|
|
There was a problem hiding this comment.
You don't need to update CHANGELOG in this PR, it's usually updated in release time.
There was a problem hiding this comment.
sgtm! Updated w/o this change.
nipunn1313
force-pushed
the
unneeded_field_pattern
branch
from
11ab30c
to
dd8f641
Compare
clippy_lints/src/misc_early.rs
Outdated
| @@ -25,7 +25,7 @@ declare_clippy_lint! { | |||
| /// let { a: _, b: ref b, c: _ } = .. | |||
| /// ``` | |||
| pub UNNEEDED_FIELD_PATTERN, | |||
| style, | |||
| pedantic, | |||
There was a problem hiding this comment.
I agree with @gnzlbg , that this should probably even be a restriction lint, so that you have to opt-in.
There was a problem hiding this comment.
I can make that change if you request it.
Pedantic is described as
`clippy::pedantic` (lints which are rather strict, off by default)
Restriction is described as
The [lint list](https://rust-lang.github.io/rust-clippy/master/index.html) also contains "restriction lints", which are
for things which are usually not considered "bad", but may be useful to turn on in specific cases. These should be used
very selectively, if at all.
I'll switch it to restriction which seems to match this better.
There was a problem hiding this comment.
which are usually not considered "bad"
I think this perfectly matches this lint 👍
nipunn1313
force-pushed
the
unneeded_field_pattern
branch
from
dd8f641
to
78a2507
Compare
nipunn1313
changed the title
|
@bors r+ |
|
📌 Commit 78a2507 has been approved by |
Move unneeded_field_pattern to restriction group Fixes #1741 changelog: Move unneeded_field_pattern to pedantic group
|
@bors retry |
Move unneeded_field_pattern to restriction group Fixes #1741 changelog: Move unneeded_field_pattern to pedantic group
|
💔 Test failed - checks-action_test |
|
@bors retry |
Move unneeded_field_pattern to restriction group Fixes #1741 changelog: Move unneeded_field_pattern to pedantic group
|
💔 Test failed - checks-action_test |
flip1995
added
the
S-waiting-on-bors
|
@bors retry (finally) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fixes #1741
changelog: Move unneeded_field_pattern to pedantic group