Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try_eval_usize over eval_usize #5256

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Use try_eval_usize over eval_usize #5256

merged 2 commits into from
Mar 3, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #5223

changelog: Fix ICE in evaluating usizes

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 2, 2020
@phansch
Copy link
Member

phansch commented Mar 3, 2020

Hm, some test cases for these fixes would be nice. Apart from that, it looks good 👍

@phansch phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 3, 2020
@JohnTitor JohnTitor changed the title Use try_eval_usize over eval_usize [WIP] Use try_eval_usize over eval_usize Mar 3, 2020
@JohnTitor JohnTitor changed the title [WIP] Use try_eval_usize over eval_usize Use try_eval_usize over eval_usize Mar 3, 2020
@JohnTitor
Copy link
Member Author

Added two test cases.

@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Mar 3, 2020
@phansch
Copy link
Member

phansch commented Mar 3, 2020

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Mar 3, 2020

📌 Commit 46ee6b1 has been approved by phansch

@bors
Copy link
Contributor

bors commented Mar 3, 2020

⌛ Testing commit 46ee6b1 with merge d74229b...

@bors
Copy link
Contributor

bors commented Mar 3, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing d74229b to master...

@bors bors merged commit d74229b into rust-lang:master Mar 3, 2020
@JohnTitor JohnTitor deleted the try-eval-usize branch March 3, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Const generics: Clippy: "expected bits of usize, got Const"
3 participants
@JohnTitor @phansch @bors