Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro use sugg #5279

Merged
merged 10 commits into from
Jun 9, 2020
Merged

Macro use sugg #5279

merged 10 commits into from
Jun 9, 2020

Commits on Jun 8, 2020

  1. warn on macro_use attr 

    cargo dev update lints

use if_chain

clean up alot, span_lint_and_sugg

find imported macros for sugg
    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    a4b8bb8 View commit details
    Browse the repository at this point in the history

  2. collected all the imports and names 

    how to compare macro to import path

add more imports to test
    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    ede366b View commit details
    Browse the repository at this point in the history

  3. use hashset not map for keeping track of seen macro refs 

    remove stdout, fix clippy warnings, fmtcar
    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    8ffbf6f View commit details
    Browse the repository at this point in the history

  4. remove session

    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    1d9e80a View commit details
    Browse the repository at this point in the history

  5. fix some of the review, rename, fmt, refactor

    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    8bc106b View commit details
    Browse the repository at this point in the history

  6. still working on displaying nested imports

    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    451363d View commit details
    Browse the repository at this point in the history

  7. wip: of handling nested import paths for multi-macro paths

    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    d4f60b5 View commit details
    Browse the repository at this point in the history

  8. cleaned up import suggestion formatter, look into code reuse with wil… 

    …dcard impotrs
    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    8c5a5a9 View commit details
    Browse the repository at this point in the history

  9. Fix suggestion output, add run-rustfix to test file, stop sorting imp… 

    …ort segments duh
    @DevinR528
    DevinR528 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    288df59 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Add enough attrs to the test file so the fix compiles with no errors,… 

    … fmt/`clippy`
    @DevinR528
    DevinR528 committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    e521a4e View commit details
    Browse the repository at this point in the history