Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't emit lifetime lint warnings for code inside macros. #5293

Merged
merged 1 commit into from
Mar 30, 2020
Merged

don't emit lifetime lint warnings for code inside macros. #5293

merged 1 commit into from
Mar 30, 2020

Conversation

matthiaskrgr
Copy link
Member

Fixes #5283

changelog: Don't emit lifetime lint warnings for code inside macros.

@matthiaskrgr
Copy link
Member Author

Note that this is not tested as I'm not smart enough to write macros that contain lifetimes :(

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 9, 2020
@bors
Copy link
Contributor

bors commented Mar 30, 2020

☔ The latest upstream changes (presumably #5392) made this pull request unmergeable. Please resolve the merge conflicts.

@phansch phansch self-requested a review March 30, 2020 16:00
@phansch
Copy link
Member

phansch commented Mar 30, 2020

The fix looks correct to me and I confirmed that it works locally 👍 I would be fine with creating a separate issue for the test case to get this merged.

r=me with rebase and issue created

@phansch phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 30, 2020
@matthiaskrgr
Copy link
Member Author

I think it's better to just reopen the "fixed" issue afterwards since it already contains all the information? (I added the needs-test label already).

@matthiaskrgr
Copy link
Member Author

@bors r=phansch

@bors
Copy link
Contributor

bors commented Mar 30, 2020

📌 Commit 8e83afa has been approved by phansch

@bors
Copy link
Contributor

bors commented Mar 30, 2020

⌛ Testing commit 8e83afa with merge 1cac2f9...

@bors
Copy link
Contributor

bors commented Mar 30, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 1cac2f9 to master...

@bors bors merged commit 1cac2f9 into rust-lang:master Mar 30, 2020
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip needless_lifetimes inside macros (needs test!)
4 participants
@matthiaskrgr @bors @phansch @flip1995