integer_arithmetic: detect integer arithmetic on references. #5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Mar 18, 2020
flip1995
added
the
S-waiting-on-author
Also fixes the same for float_arithmetic. changelog: integer_arithmetic,float_arithmetic: fix false negatives with references on integers Fixes rust-lang#5328
matthiaskrgr
force-pushed
the
int_arith_on_ref_5328
branch
from
7f0d8b3
to
c7c7ab2
Compare
flip1995
reviewed
Mar 18, 2020
tests/ui/arithmetic.stderr
Outdated
| LL | (&f1 + &f2) | ||
| | ^^^^^^^^^^^ | ||
|
|
||
| error: aborting due to 34 previous errors | ||
|
|
There was a problem hiding this comment.
Wait this should fail the --limit-stderr-length test 🤔
There was a problem hiding this comment.
Should I split up the into two, one for float and one for int arithmetic?
There was a problem hiding this comment.
Would be good. I just pushed the fix for this here. So please pull before splitting up the tests.
|
@bors r+ Thanks! |
|
📌 Commit ec1dcde has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: integer_arithmetic fix false negatives with references on integers
Fixes #5328