Rollup up 3 pull requests #5339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustups rust-lang/rust#69189 which is part of rust-lang/rust#70085 (at least I think this is the only pr that changes clippy test stdout)
|
@bors r+ |
|
📌 Commit a1cfd7c has been approved by |
bors
added a commit
that referenced
this pull request
Mar 19, 2020
Rollup up 3 pull requests changelog: none We need all of these merging at the same time.
|
💔 Test failed - checks-action_test |
looks spurious 🤔 @bors retry |
bors
added a commit
that referenced
this pull request
Mar 19, 2020
Rollup up 3 pull requests changelog: none We need all of these merging at the same time.
|
💔 Test failed - checks-action_test |
|
|
@bors try |
bors
added a commit
that referenced
this pull request
Mar 19, 2020
Rollup up 3 pull requests changelog: none We need all of these merging at the same time.
|
💔 Test failed - checks-action_test |
|
@bors try |
bors
added a commit
that referenced
this pull request
Mar 19, 2020
Rollup up 3 pull requests changelog: none We need all of these merging at the same time.
|
For debugging you could add before the extract binary step. This will show which files get produced by compiling the integration test. |
|
@bors try |
bors
added a commit
that referenced
this pull request
Mar 19, 2020
Rollup up 3 pull requests changelog: none We need all of these merging at the same time.
yeah, somehow the test binary is not produced. |
flip1995
requested changes
Mar 19, 2020
Comment on lines
+1
to
+7
| error: transmute from a type (`&T`) to itself | ||
| --> $DIR/transmute_ptr_to_ptr.rs:8:5 | ||
| | | ||
| LL | std::mem::transmute::<&'a T, &'static T>(t) | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| | | ||
| = note: `-D clippy::useless-transmute` implied by `-D warnings` |
There was a problem hiding this comment.
We explicitly don't want to lint this. See my comment in #5333 (comment)
|
💔 Test failed - checks-action_test |
|
This should fix it: diff --git a/.github/workflows/clippy_bors.yml b/.github/workflows/clippy_bors.yml
index a4f7b64c..8393b16d 100644
--- a/.github/workflows/clippy_bors.yml
+++ b/.github/workflows/clippy_bors.yml
@@ -209,7 +209,7 @@ jobs:
run: |
DIR=$CARGO_TARGET_DIR/debug
find $DIR ! -executable -o -type d ! -path $DIR | xargs rm -rf
- mv $DIR/integration-* $DIR/integration
+ mv $DIR/deps/integration-* $DIR/integration
rm -rf $CARGO_TARGET_DIR/release
- name: Upload Binaries |
|
We'll need another rustup: #66131 I'm working on it. I'll open a new rollup PR, once it's ready. @bors treeclosed=1000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none
We need all of these merging at the same time.