Code

Rollup of 11 pull requests#5438

Code

Merged

bors merged 39 commits intorust-lang:masterrust-lang/rust-clippy:masterfrom flip1995:rollup-pi762oyflip1995/rust-clippy:rollup-pi762oyCopy head branch name to clipboardApr 8, 2020

+687-532

Commits

Commits on Apr 3, 2020

• Downgrade let_unit_value to pedantic

  dtolnay

  committed
  adcaa1b

  Copy full SHA for adcaa1b

• Downgrade trivially_copy_pass_by_ref to pedantic

  dtolnay

  committed
  94154ca

  Copy full SHA for 94154ca

• Downgrade inefficient_to_string to pedantic

  dtolnay

  committed
  e26ae7a

  Copy full SHA for e26ae7a

• Clean up update_lints

  flip1995

  committed
  ffb2e41

  Copy full SHA for ffb2e41

• Get rid of Lint::is_internal method

  flip1995

  committed
  da67982

  Copy full SHA for da67982

• Build lint lists once and the reuse them to update files

  flip1995

  committed
  98c30fe

  Copy full SHA for 98c30fe

• Don't filter lints in code generation functions

  flip1995

  committed
  a186d9f

  Copy full SHA for a186d9f

• Make lint modules private

  flip1995

  committed
  d89bb50

  Copy full SHA for d89bb50

• Run update_lints

  flip1995

  committed
  045722a

  Copy full SHA for 045722a

• Move matches test in matches module

  flip1995

  committed
  30503a9

  Copy full SHA for 30503a9

Commits on Apr 4, 2020

• result_map_or_into_option: add lint to catch manually adpating Result -> Option

  Show description for 91d8a80
  nickrtorres

  committed
  91d8a80

  Copy full SHA for 91d8a80

• Rename rustc -> rustc_middle in doc links

  flip1995

  committed
  2481d3c

  Copy full SHA for 2481d3c

• Update CONTRIBUTING.md

  flip1995

  committed
  fac5a41

  Copy full SHA for fac5a41

• Downgrade unreadable_literal to pedantic

  dtolnay

  committed
  be34bc4

  Copy full SHA for be34bc4

• Downgrade new_ret_no_self to pedantic

  dtolnay

  committed
  560c8c9

  Copy full SHA for 560c8c9

• result_map_or_into_option: explicitly note absence of known problems

  nickrtorres

  committed
  91759a7

  Copy full SHA for 91759a7

• result_map_or_into_option: add good and bad examples

  nickrtorres

  committed
  3a29aed

  Copy full SHA for 3a29aed

• result_map_or_into_option: destructure lint tuple or return early

  nickrtorres

  committed
  d0738bd

  Copy full SHA for d0738bd

• result_map_or_into_option: add opt.map_or(None, |_| Some(y)) test

  nickrtorres

  committed
  fb276dc

  Copy full SHA for fb276dc

• result_map_or_into_option: move arg checks into tuple assignment

  nickrtorres

  committed
  acc3bc1

  Copy full SHA for acc3bc1

• result_map_or_into_option: fix cargo dev fmt --check errors

  nickrtorres

  committed
  2533f56

  Copy full SHA for 2533f56

• CONTRIBUTING.md: fix broken triage link

  nickrtorres

  committed
  fecdb72

  Copy full SHA for fecdb72

• result_map_or_into: fix dogfood_clippy error => {h,l}int

  nickrtorres

  committed
  325d0b6

  Copy full SHA for 325d0b6

Commits on Apr 5, 2020

• result_map_or_into_option: fix syntax error in example

  nickrtorres

  committed
  5d54fbb

  Copy full SHA for 5d54fbb

• Include OpAssign in suspicious_op_assign_impl

  jpospychala

  committed
  9c9af1d

  Copy full SHA for 9c9af1d

Commits on Apr 6, 2020

• Lint on opt.as_ref().map(|x| &**x).

  xiongmao86

  committed
  4f14826

  Copy full SHA for 4f14826

Commits on Apr 7, 2020

• Refine lint message.

  xiongmao86

  committed
  d7056f8

  Copy full SHA for d7056f8

Commits on Apr 8, 2020

• Rollup merge of rust-lang#5406 - flip1995:update_lints_fix, r=flip1995

  Show description for 46337cb
  flip1995

  authored
  46337cb

  Copy full SHA for 46337cb

• Rollup merge of rust-lang#5409 - dtolnay:letunit, r=flip1995

  Show description for 935b45d
  flip1995

  authored
  935b45d

  Copy full SHA for 935b45d

• Rollup merge of rust-lang#5410 - dtolnay:trivially, r=flip1995

  Show description for 1e1bd51
  flip1995

  authored
  1e1bd51

  Copy full SHA for 1e1bd51

• Rollup merge of rust-lang#5412 - dtolnay:tostring, r=flip1995

  Show description for 5ea4771
  flip1995

  authored
  5ea4771

  Copy full SHA for 5ea4771

• Rollup merge of rust-lang#5415 - nickrtorres:master, r=flip1995

  Show description for a1e49f9
  flip1995

  authored
  a1e49f9

  Copy full SHA for a1e49f9

• Rollup merge of rust-lang#5417 - flip1995:doc_update, r=flip1995

  Show description for f84b72b
  flip1995

  authored
  f84b72b

  Copy full SHA for f84b72b

• Rollup merge of rust-lang#5419 - dtolnay:unreadable, r=flip1995

  Show description for 2011d9a
  flip1995

  authored
  2011d9a

  Copy full SHA for 2011d9a

• Rollup merge of rust-lang#5420 - dtolnay:newret, r=flip1995

  Show description for 7cb5180
  flip1995

  authored
  7cb5180

  Copy full SHA for 7cb5180

• Rollup merge of rust-lang#5422 - nickrtorres:contributing-triage, r=flip1995

  Show description for b42bd19
  flip1995

  authored
  b42bd19

  Copy full SHA for b42bd19

• Rollup merge of rust-lang#5424 - jpospychala:suspicious_op_assign_impl, r=flip1995

  Show description for 8fc592a
  flip1995

  authored
  8fc592a

  Copy full SHA for 8fc592a

• Rollup merge of rust-lang#5425 - xiongmao86:issue5367, r=flip1995

  Show description for 79d1521
  flip1995

  authored
  79d1521

  Copy full SHA for 79d1521

• Run fmt and update test

  flip1995

  committed
  381f9cb

  Copy full SHA for 381f9cb