Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some accuracy lints for floating point operations #5443

Merged
merged 9 commits into from
Jul 13, 2020
Merged

Some accuracy lints for floating point operations #5443

merged 9 commits into from
Jul 13, 2020

Commits on Jul 6, 2020

  1. Lint for x.powi(2) => x * x

    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a6f1af7 View commit details
    Browse the repository at this point in the history

  2. Lint (x * x + y * y).sqrt() => x.hypot(y)

    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    f627984 View commit details
    Browse the repository at this point in the history

  3. Lint x.log(b) / y.log(b) => x.log(y)

    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    0c8afa3 View commit details
    Browse the repository at this point in the history

  4. Lint for to_radians and to_degrees

    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    076ec87 View commit details
    Browse the repository at this point in the history

  5. Better copy for lint message 

    Since x.log(y) is actually implemented as x.ln() / y.ln()
    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    f559682 View commit details
    Browse the repository at this point in the history

  6. Place radian lints under suboptimal_flops

    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    db7bc6b View commit details
    Browse the repository at this point in the history

  7. Includes TODO comment for hypot lint

    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6dc066f View commit details
    Browse the repository at this point in the history

  8. Reclassify powi(2) lint under suboptimal_flops

    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6be9491 View commit details
    Browse the repository at this point in the history

  9. Includes TODO for constants equivalent to π/180

    @thiagoarrais
    thiagoarrais committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    3065201 View commit details
    Browse the repository at this point in the history