Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare with the second largest instead of the smallest variant #5446

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Apr 10, 2020

This should make the lint less noisy for now. See my comment to issue #5418.


changelog: none

@llogiq
Copy link
Contributor Author

llogiq commented Apr 10, 2020

r? @flip1995

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2020

📌 Commit 89f6012 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Apr 10, 2020

⌛ Testing commit 89f6012 with merge c17ae44...

bors added a commit that referenced this pull request Apr 10, 2020
compare with the second largest instead of the smallest variant

This should make the lint less noisy for now. See [my comment](#5418 (comment)) to issue #5418.

---

changelog: none
@bors
Copy link
Contributor

bors commented Apr 10, 2020

💔 Test failed - checks-action_test

@phansch
Copy link
Member

phansch commented Apr 10, 2020

@bors retry

@bors
Copy link
Contributor

bors commented Apr 10, 2020

⌛ Testing commit 89f6012 with merge 0353f21...

@bors
Copy link
Contributor

bors commented Apr 10, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 0353f21 to master...

@bors bors merged commit 0353f21 into master Apr 10, 2020
@llogiq llogiq deleted the gimme-a-second branch April 10, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants