Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map flatten for option #5473

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Map flatten for option #5473

merged 2 commits into from
Apr 16, 2020

Conversation

marcin-serwin
Copy link
Contributor

Fixes #5175

changelog:

  • Trigger the map_flatten lint when map is called on an option
  • Add test for such case

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 16, 2020
flip1995
flip1995 approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we're currently struggling with CI, but will merge this once CI works again.

@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 16, 2020
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 16, 2020

📌 Commit 72a8fc2 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Apr 16, 2020

⌛ Testing commit 72a8fc2 with merge c1c8bc6...

@bors
Copy link
Collaborator

bors commented Apr 16, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing c1c8bc6 to master...

@bors bors merged commit c1c8bc6 into rust-lang:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option::map(_).flatten() => Option::and_then(_)
4 participants
@marcin-serwin @flip1995 @bors @phansch