Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit_arg suggestion is not really machine-applicable #5480

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Apr 17, 2020

This lint suggests replacing any code returining ()-type with () literal, which can change the behavior. e.g. Ok(do_something()) -> OK(()).


changelog: none

@flip1995
Copy link
Member

Yeah: #4455

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 17, 2020

📌 Commit 162cf26 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Apr 17, 2020

⌛ Testing commit 162cf26 with merge 8ae143f...

@bors
Copy link
Collaborator

bors commented Apr 17, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8ae143f to master...

@bors bors merged commit 8ae143f into rust-lang:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants