len_zero: skip ranges if feature range_is_empty is not enabled
#5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
matthiaskrgr
approved these changes
May 28, 2020
|
@bors r=matthiaskrgr |
|
📌 Commit 64a05f5 has been approved by |
bors
added a commit
that referenced
this pull request
May 28, 2020
len_zero: skip ranges if feature `range_is_empty` is not enabled If the feature is not enabled, calling `is_empty()` on a range is ambiguous. Moreover, the two possible resolutions are unstable methods, one inherent to the range and the other being part of the `ExactSizeIterator` trait. Since `len_zero` only checks for existing `is_empty()` inherent methods, we only take into account the `range_is_empty` feature. Related: rust-lang/rust#48111 (comment) changelog: len_zero: avoid linting ranges without #![feature(range_is_empty)] Fixes: #3807
|
💔 Test failed - checks-action_test |
|
Looks like we need another rustup https://github.com/rust-lang/rust-clippy/runs/716588484#step:12:43 |
matthiaskrgr
added
S-waiting-on-bors
|
I wait until rust-lang/rust#72671 is merged and will then do the rustup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the feature is not enabled, calling
is_empty()on a range is ambiguous. Moreover, the two possible resolutions are unstable methods, one inherent to the range and the other being part of theExactSizeIteratortrait.Since
len_zeroonly checks for existingis_empty()inherent methods, we only take into account therange_is_emptyfeature.Related: rust-lang/rust#48111 (comment)
changelog: len_zero: avoid linting ranges without #![feature(range_is_empty)]
Fixes: #3807