Skip to content

Add a lint for starts_with #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
llogiq merged 2 commits into from
Jan 20, 2016
Merged

Add a lint for starts_with #566

llogiq merged 2 commits into from
Jan 20, 2016

Conversation

@mcarton
Copy link
Contributor

@mcarton mcarton commented Jan 20, 2016

No description provided.

@llogiq
Copy link
Contributor

llogiq commented Jan 20, 2016

Does this have a macro check that I overlooked? Otherwise I'd add one just to be on the safe side.

@mcarton
Copy link
Contributor Author

mcarton commented Jan 20, 2016

Nope. Currently none of the lints in src/methods.rs have one. It causes false positive with str_to_string in racer (see #553). All lints in this function should probably have one. What do you think?

llogiq added a commit that referenced this pull request Jan 20, 2016
@llogiq
Merge pull request #566 from mcarton/starts_with
c570fc6 
Add a lint for starts_with
@llogiq llogiq merged commit c570fc6 into rust-lang:master Jan 20, 2016
@llogiq
Copy link
Contributor

llogiq commented Jan 20, 2016

Thank you!

@mcarton mcarton deleted the starts_with branch January 20, 2016 19:15
@mcarton mcarton mentioned this pull request Feb 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcarton @llogiq