Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved cast_ptr_alignment to pedantic and expanded documentation #5667

Merged
merged 2 commits into from
May 31, 2020
Merged

moved cast_ptr_alignment to pedantic and expanded documentation #5667

merged 2 commits into from
May 31, 2020

Conversation

djugei
Copy link
Contributor

@djugei djugei commented May 31, 2020

fixes: #5618
changelog: cast_ptr_alignment moved to pedantic

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthiaskrgr (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 31, 2020
@flip1995
Copy link
Member

@djugei You have to run cargo dev update_lints once.

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 31, 2020
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 31, 2020

📌 Commit 18b5cee has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 31, 2020

⌛ Testing commit 18b5cee with merge 8aa8f42...

@bors
Copy link
Contributor

bors commented May 31, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8aa8f42 to master...

@bors bors merged commit 8aa8f42 into rust-lang:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthiaskrgr matthiaskrgr

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in cast_ptr_alignment
5 participants
@djugei @rust-highfive @flip1995 @bors @matthiaskrgr