Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reversed_empty_ranges: avoid linting N..N except in for loop arguments #5692

Merged
merged 2 commits into from
Jun 8, 2020
Merged

reversed_empty_ranges: avoid linting N..N except in for loop arguments #5692

merged 2 commits into from
Jun 8, 2020

Conversation

ebroto
Copy link
Member

@ebroto ebroto commented Jun 7, 2020

changelog: [reversed_empty_ranges]: avoid linting N..N except in for loop arguments

r? @yaahc
Fixes #5689

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 7, 2020
yaahc
yaahc approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@yaahc yaahc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @flip1995

@flip1995
Copy link
Member

flip1995 commented Jun 8, 2020

@bors r=yaahc

@bors
Copy link
Contributor

bors commented Jun 8, 2020

📌 Commit a664ce7 has been approved by yaahc

@bors
Copy link
Contributor

bors commented Jun 8, 2020

⌛ Testing commit a664ce7 with merge ff0993c...

@bors
Copy link
Contributor

bors commented Jun 8, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: yaahc
Pushing ff0993c to master...

@bors bors merged commit ff0993c into rust-lang:master Jun 8, 2020
@ebroto ebroto deleted the 5689_N_dotdot_N branch June 8, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaahc yaahc yaahc approved these changes

Assignees

@yaahc yaahc

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in reversed_empty_ranges used with Vec::splice
5 participants
@ebroto @flip1995 @bors @yaahc @rust-highfive