Rename collapsable_if fix suggestion to "collapse nested if block"

[bjorn3]

The name "try" is confusing when shown as quick fix by rust-analyzer

changelog: Rename collapsable_if fix suggestion to "collapse nested if block"

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[mati865]

I think this is how most of Clippy lints look like.
Even doc span_lint_and_sugg does that:

rust-clippy/clippy_lints/src/utils/diagnostics.rs

Line 168 in 6ae0643

/// In the example below, `help` is `"try"` and `sugg` is the suggested replacement `".any(|x| x >

[bjorn3]

Having a generic name like try is very confusing in ide cases. And if there are multiple lints that trigger on the same piece of code, there is literally no way to know which try applies which suggestion.

[mati865]

I'm not opposed. Fixing all the lints will require a lot of work though.

[flip1995]

You will need to update the stderr reference files. You can do this by running cargo uitest followed by sh tests/ui/update-all-references.sh. Everything else LGTM.

The name "try" is confusing when shown as quick fix by rust-analyzer

I will take this in consideration when reviewing future lints, thanks for the feedback!

r? @flip1995

[flip1995]

Friendly ping @bjorn3 . Can you update the stderr files, so we can merge this?

[bjorn3]

Thanks for the ping. Updated the stderr files, rebased and squashed.

[flip1995]

Thanks!

@bors r+

[bors]

📌 Commit ff796b6 has been approved by flip1995

[bors]

⌛ Testing commit ff796b6 with merge 2ca58e7...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 2ca58e7 to master...