single_match_else - single expr/stmt else block corner case #5771
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| // don't lint here | ||
| match Some(1) { | ||
| Some(a) => println!("${:?}", a), | ||
| None => return, | ||
| } | ||
|
|
||
| // don't lint here | ||
| match Some(1) { | ||
| Some(a) => println!("${:?}", a), | ||
| None => return, | ||
| } |
There was a problem hiding this comment.
is this supposed to be the same?
There was a problem hiding this comment.
ah my bad, this is supposed to be the {return} case
There was a problem hiding this comment.
I know now, forgot to skip rustfmt on those cases.
tnielens
force-pushed
the
bugfix/single-match-else
branch
from
1ed3582 to
c8c286c
Compare
|
Thanks, can you please run rustfmt? I see some trailing whitespaces. |
tnielens
force-pushed
the
bugfix/single-match-else
branch
from
c8c286c to
dac19e3
Compare
|
That's strange. Thanks! @bors r+ |
|
📌 Commit dac19e3 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
4 participants
One approach to fix #3489.
See discussion in the issue.
changelog: single_match_else - single expr/stmt else block corner case fix