Add lint for duplicate methods of trait bounds #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
wiomoc
force-pushed
the
feature/lint-duplicate-trait
branch
from
841dab7
to
48900a2
Compare
wiomoc
force-pushed
the
feature/lint-duplicate-trait
branch
from
48900a2
to
94c50bc
Compare
giraffate
reviewed
Jul 29, 2020
|
A nice thing to do here would be to add a suggestion, that can auto-remove those bounds. But this involves some effort, so it should can be done in another PR. |
flip1995
added
S-waiting-on-bors
|
📌 Commit e521c67 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 3, 2020
Add lint for duplicate methods of trait bounds rel: #5777 changelog: Add [`trait_duplication_in_bounds`] lint
|
💔 Test failed - checks-action_test |
|
Yeah, I would probably do this by modifying the ast and pretty printing it |
|
Blocked on #5864 |
|
@bors r=Manishearth rollup=always |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit e521c67 has been approved by |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 4, 2020
… r=Manishearth Add lint for duplicate methods of trait bounds rel: rust-lang#5777 changelog: Add [`trait_duplication_in_bounds`] lint
bors
added a commit
that referenced
this pull request
Aug 4, 2020
Rollup of 6 pull requests Successful merges: - #5725 (should_impl_trait - ignore methods with lifetime params) - #5837 (needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...) - #5846 (Handle mapping to Option in `map_flatten` lint) - #5848 (Add derive_ord_xor_partial_ord lint) - #5852 (Add lint for duplicate methods of trait bounds) - #5856 (Remove old Symbol reexport) Failed merges: r? @ghost changelog: rollup
bors
added a commit
that referenced
this pull request
Aug 4, 2020
Rollup of 6 pull requests Successful merges: - #5725 (should_impl_trait - ignore methods with lifetime params) - #5837 (needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...) - #5846 (Handle mapping to Option in `map_flatten` lint) - #5848 (Add derive_ord_xor_partial_ord lint) - #5852 (Add lint for duplicate methods of trait bounds) - #5856 (Remove old Symbol reexport) Failed merges: r? @ghost changelog: rollup
bors
added a commit
that referenced
this pull request
Aug 4, 2020
Rollup of 5 pull requests Successful merges: - #5837 (needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...) - #5846 (Handle mapping to Option in `map_flatten` lint) - #5848 (Add derive_ord_xor_partial_ord lint) - #5852 (Add lint for duplicate methods of trait bounds) - #5856 (Remove old Symbol reexport) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Aug 4, 2020
Rollup of 5 pull requests Successful merges: - #5837 (needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...) - #5846 (Handle mapping to Option in `map_flatten` lint) - #5848 (Add derive_ord_xor_partial_ord lint) - #5852 (Add lint for duplicate methods of trait bounds) - #5856 (Remove old Symbol reexport) Failed merges: r? @ghost changelog: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel: #5777
changelog: Add [
trait_duplication_in_bounds] lint