Widen understanding of prelude import #5929
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
r? @ebroto |
ebroto
added
S-waiting-on-author
|
@ebroto I did apply your suggested change, but the build seems to break in CI on a different issue, which I can't reproduce locally, but it seems to affect other recent CI runs. I'll wait for a fix before assigning this back to you. Edit: since the error message relates to |
FYI this happens every once and then, and as you saw it's not related to your PR. When rustc breaks clippy we need to sync the changes manually so that we can build against the master branch of rustc again. This may change in the near future (if we manage to pin to a nightly).
On the other hand, bors merges with master to test so this should be fine (sorry, I'm new here 😅) |
|
📌 Commit 422c07c has been approved by |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 422c07c has been approved by |
Widen understanding of prelude import Prelude imports are exempt from wildcard import warnings. Until now only imports of the form ``` use ...::prelude::*; ``` were considered. This change makes it so that the segment `prelude` can show up anywhere, for instance: ``` use ...::prelude::v1::*; ``` Fixes #5917 changelog: Allow `prelude` to appear in any segment of the import path in [`wildcard_imports`]
|
💔 Test failed - checks-action_test |
|
It seems the rebase is necessary in this case |
Prelude imports are exempt from wildcard import warnings. Until now only imports of the form ``` use ...::prelude::*; ``` were considered. This change makes it so that the segment `prelude` can show up anywhere, for instance: ``` use ...::prelude::v1::*; ``` Fixes rust-lang#5917
|
Thanks for your help, @ebroto . It's all green now :) |
|
@bors retry Thanks! |
|
@bors are you still there? |
|
🍰 Target acquired
|
|
@bors r=ebroto |
|
📌 Commit e615a26 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Prelude imports are exempt from wildcard import warnings. Until now only
imports of the form
were considered. This change makes it so that the segment
preludecanshow up anywhere, for instance:
Fixes #5917
changelog: Allow
preludeto appear in any segment of the import path in [wildcard_imports]