Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable_sort_primitive: print the type that is being sorted in the lint message #5935

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

matthiaskrgr
Copy link
Member

changelog: stable_sort_primitive: print the type that is being sorted in the lint message

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 21, 2020
@matthiaskrgr matthiaskrgr force-pushed the unstable_sort_ty_name branch 3 times, most recently from 94b65d7 to 331e07b Compare August 22, 2020 18:29
@@ -111,9 +112,10 @@ impl LateLintPass<'_> for StableSortPrimitive {
STABLE_SORT_PRIMITIVE,
expr.span,
format!(
"used {} instead of {}",
"used {} instead of {} to sort primitive type {}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:

Suggested change
"used {} instead of {} to sort primitive type {}",
"used {} instead of {} to sort primitive type `{}`",

r=me with this change and reference files updated.

@matthiaskrgr matthiaskrgr force-pushed the unstable_sort_ty_name branch from 331e07b to e9964f2 Compare August 24, 2020 18:07
@matthiaskrgr
Copy link
Member Author

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Aug 24, 2020

📌 Commit e9964f2 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Aug 24, 2020

⌛ Testing commit e9964f2 with merge 8d9a485...

@bors
Copy link
Contributor

bors commented Aug 24, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8d9a485 to master...

@bors bors merged commit 8d9a485 into rust-lang:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants