Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a fp in transmute_ptr_to_ptr #5999

Merged

Conversation

rail-rain
Copy link
Contributor

fixes #5959

changelog: Fix a false positive in transmute_ptr_to_ptr that the lint fires when transmute is used to cast a reference in const contexts although dereferencing raw pointers in consts is unstable.

Avoid firing the lint when `transmute` in const contexts
as dereferencing raw pointers in consts is unstable. cc rust-lang#5959
@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 1, 2020
@ebroto
Copy link
Member

ebroto commented Sep 1, 2020

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Sep 1, 2020

📌 Commit afeb917 has been approved by ebroto

@bors
Copy link
Collaborator

bors commented Sep 1, 2020

⌛ Testing commit afeb917 with merge 48248af...

@bors
Copy link
Collaborator

bors commented Sep 1, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 48248af to master...

@bors bors merged commit 48248af into rust-lang:master Sep 1, 2020
@rail-rain rail-rain deleted the fix_fp_transmute_ptr_to_ptr_in_consts branch September 1, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transmute_ptr_to_ptr: False positive when using transmute in consts
5 participants