Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print the unit type () in related lint messages. #6024

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

matthiaskrgr
Copy link
Member

changelog: print the unit type () in related lint messages

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 9, 2020
@phansch
Copy link
Member

phansch commented Sep 10, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 10, 2020

📌 Commit de195f2 has been approved by phansch

@bors
Copy link
Contributor

bors commented Sep 10, 2020

⌛ Testing commit de195f2 with merge 990e88c...

bors added a commit that referenced this pull request Sep 10, 2020
print the unit type `()` in related lint messages.

changelog: print the unit type `()` in related lint messages
@bors
Copy link
Contributor

bors commented Sep 10, 2020

💔 Test failed - checks-action_test

@phansch
Copy link
Member

phansch commented Sep 10, 2020

looks spurious @bors retry

@bors
Copy link
Contributor

bors commented Sep 10, 2020

⌛ Testing commit de195f2 with merge c552dcf...

bors added a commit that referenced this pull request Sep 10, 2020
print the unit type `()` in related lint messages.

changelog: print the unit type `()` in related lint messages
@bors
Copy link
Contributor

bors commented Sep 10, 2020

💔 Test failed - checks-action_test

@phansch
Copy link
Member

phansch commented Sep 10, 2020

still spurious: Connection reset by peer (os error 104)

@bors retry

@bors
Copy link
Contributor

bors commented Sep 10, 2020

⌛ Testing commit de195f2 with merge e0f46a1...

@bors
Copy link
Contributor

bors commented Sep 10, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing e0f46a1 to master...

@bors bors merged commit e0f46a1 into rust-lang:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants