Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{print,write}-with-newline: do not suggest empty format string #6042

Merged
merged 1 commit into from
Sep 16, 2020
Merged

{print,write}-with-newline: do not suggest empty format string #6042

merged 1 commit into from
Sep 16, 2020

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Sep 14, 2020 •
edited
Loading

changelog: do not suggest empty format strings in print-with-newline and write-with-newline

@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 14, 2020
@euclio
Copy link
Contributor Author

euclio commented Sep 14, 2020

Oops, this is not quite ready to go: I need to get write_with_newline to work as well.

@euclio euclio changed the title print-with-newline: do not suggest println!("") {print,write}-with-newline: do not suggest empty format string Sep 16, 2020
@euclio
Copy link
Contributor Author

euclio commented Sep 16, 2020

Updated. I'm not super happy about the span on writeln!, but I'm not sure trying to finagle the span to include the , is worth it. Unfortunately rustfmt won't take care of it.

@flip1995
Copy link
Member

I agree that also removing the , would be way too much code for little benefit. This is definitely an improvement of the current suggestion as it is. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 16, 2020

📌 Commit 0261e34 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Sep 16, 2020

⌛ Testing commit 0261e34 with merge 61dd007...

@bors
Copy link
Contributor

bors commented Sep 16, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 61dd007 to master...

@bors bors merged commit 61dd007 into rust-lang:master Sep 16, 2020
@euclio euclio deleted the println-empty branch September 16, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@euclio @rust-highfive @flip1995 @bors @Manishearth