new lints len_zero and len_without_is_empty #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Manishearth Did you change travis to stable? The build is failing. Also my last commit can probably be reverted. |
|
Travis changed itself to default to stable. I did locally fix this for all my crates, but I had flaky internet and the clippy push probably didn't go through. |
|
|
||
| #[deny(len_without_is_empty)] | ||
| impl One { | ||
| fn len(self: &Self) -> isize { //~ERROR |
There was a problem hiding this comment.
Nit: keep at least the beginning bits of the error message here (and for most of the ones below too)
|
I'll close this and switch to another branch. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #60 and at least puts #32 on hold until we can have method lookup.