Preserve raw strs for: format!(s) to s.to_string() lint #6151
Conversation
Ie: | let s = format!(r#""hello""#); | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `r#""hello""#.to_string()`
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ebroto (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ Thanks for your contribution! |
|
📌 Commit 7b7ddfa has been approved by |
ebroto
removed
the
S-waiting-on-review
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #6142
clippy::useless_format will keep the source's string (after converting {{ and }} to { and }) when suggesting a change from format!() to .to_string() usage. Ie:
| let s = format!(r#""hello {{}}""#);
| ^^^^^^^^^^^^^^^^^^^^^ help: consider using
.to_string():r#""hello {}""#.to_string()changelog: [
useless_format]: preserve raw string literals when no arguments toformat!()are provided.