Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map_clone with deref and clone #6269

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Conversation

camsteffen
Copy link
Contributor

changelog: Fix map_clone false positive with deref coercion

Fixes #6239

@rust-highfive
Copy link

r? @ebroto

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 30, 2020
@camsteffen
Copy link
Contributor Author

camsteffen commented Nov 4, 2020

Learning as I go... I'm changing my implementation to check for autoderef adjustments instead of checking for impl Clone. This seems more straightforward.

@bors
Copy link
Contributor

bors commented Nov 8, 2020

☔ The latest upstream changes (presumably #6301) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@camsteffen
Copy link
Contributor Author

Rebased to fix the merge conflict.

@flip1995
Copy link
Member

flip1995 commented Nov 8, 2020

Thanks for keeping this up to date. And thanks for all your recent contributions! Sadly currently almost all of our maintainers are busy with IRL stuff and only get to review a few times a week at best.

@camsteffen
Copy link
Contributor Author

No worries!

clippy_lints/src/map_clone.rs Outdated Show resolved Hide resolved
@ebroto ebroto added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 10, 2020
@ebroto
Copy link
Member

ebroto commented Nov 11, 2020

@bors r+

Thanks! (for this and for Polite 😄)

@bors
Copy link
Contributor

bors commented Nov 11, 2020

📌 Commit 7690944 has been approved by ebroto

@bors
Copy link
Contributor

bors commented Nov 11, 2020

⌛ Testing commit 7690944 with merge c4fc076...

@bors
Copy link
Contributor

bors commented Nov 11, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing c4fc076 to master...

@bors bors merged commit c4fc076 into rust-lang:master Nov 11, 2020
@camsteffen camsteffen deleted the map-clone-deref branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map_clone suggests removing clone altogether
5 participants