Fix suggestion to add unneeded space in manual_async
#6294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Manishearth
approved these changes
Nov 5, 2020
clippy_lints/src/manual_async_fn.rs
Outdated
| if let Some(ret_pos) = header_snip.rfind("->"); | ||
| if let Some(ret_pos) = header_snip.rfind("->").map(|rpos| { | ||
| let mut rpos = rpos; | ||
| let chars: Vec<char> = header_snip.chars().collect(); |
There was a problem hiding this comment.
could you refactor this into something for utils so #6247 can also use it
There was a problem hiding this comment.
Thanks for your review! I refactored this.
giraffate
force-pushed
the
fix_suggestion_to_add_space_in_manual_async
branch
from
ef946b7 to
b7892c6
Compare
|
@bors r+ i was wondering what a good name for the function would be but this is as good as any |
|
📌 Commit b7892c6 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a same case as #6247
changelog: Fix suggestion to add unneeded space in
manual_async