Skip to content

Rustup #6319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 10, 2020
Merged

Rustup #6319

merged 6 commits into from
Nov 10, 2020

Conversation

ebroto
Copy link
Member

@ebroto ebroto commented Nov 10, 2020

changelog: none

r? @ghost

petrochenkov and others added 6 commits November 3, 2020 20:38
rustc_ast: Do not panic by default when visiting macro calls

Panicking by default made sense when we didn't have HIR or MIR and everything worked on AST, but now all AST visitors run early and majority of them have to deal with macro calls, often by ignoring them.

The second commit renames `visit_mac` to `visit_mac_call`, the corresponding structures were renamed earlier in rust-lang/rust#69589.
@ebroto
Copy link
Member Author

ebroto commented Nov 10, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 10, 2020

📌 Commit effcb52 has been approved by ebroto

@bors
Copy link
Contributor

bors commented Nov 10, 2020

⌛ Testing commit effcb52 with merge 467bf95...

@bors
Copy link
Contributor

bors commented Nov 10, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 467bf95 to master...

@bors bors merged commit 467bf95 into rust-lang:master Nov 10, 2020
@ebroto ebroto deleted the rustup branch November 10, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants