-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustup #6336
Rustup #6336
Conversation
Co-authored-by: varkor <github@varkor.com>
Make `_` an expression, to discard values in destructuring assignments This is the third and final step towards implementing destructuring assignment (RFC: rust-lang/rfcs#2909, tracking issue: #71126). This PR is the third and final part of #71156, which was split up to allow for easier review. With this PR, an underscore `_` is parsed as an expression but is allowed *only* on the left-hand side of a destructuring assignment. There it simply discards a value, similarly to the wildcard `_` in patterns. For instance, ```rust (a, _) = (1, 2) ``` will simply assign 1 to `a` and discard the 2. Note that for consistency, ``` _ = foo ``` is also allowed and equivalent to just `foo`. Thanks to ````@varkor```` who helped with the implementation, particularly around pre-expansion gating. r? ````@petrochenkov````
r? @ebroto (rust_highfive has picked a reviewer for you, use r? to override) |
because comments are checked and removed by rustfmt for some reason
c1b5f46
to
0e80341
Compare
A work around by 0e80341 addressed CI error https://github.com/rust-lang/rust-clippy/pull/6336/checks?check_run_id=1404315427. There seems to be a difference in rustfmt v1.4.26. |
@bors r+ p=1 Thanks! |
📌 Commit 0e80341 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: none