Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "WebGL" to doc_valid_idents #6388

Closed
wants to merge 1 commit into from
Closed

add "WebGL" to doc_valid_idents #6388

wants to merge 1 commit into from

Conversation

kawogi
Copy link

@kawogi kawogi commented Nov 27, 2020

I added "WebGL" along the lines of the existing "OpenGL" to the whitelist of doc_markdown as I found this to be a pretty common term.

changelog: Whitelist "WebGL" in doc_markdown.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ebroto (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 27, 2020
@kawogi
Copy link
Author

kawogi commented Nov 28, 2020

I'm new to this. How do we continue? The error seems to be unrelated to my change.

ebroto
ebroto suggested changes Nov 28, 2020
View reviewed changes
Copy link
Member

@ebroto ebroto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test for this, like in this commit?

About the error, I think it should go away after rebasing on top of the current master

@ebroto ebroto added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 28, 2020
@ebroto
Copy link
Member

ebroto commented Nov 29, 2020

And by the way, welcome to Clippy! :)

@giraffate
Copy link
Contributor

ping from triage @kawogi. Do you have any questions on how to proceed here?

@kawogi
Copy link
Author

kawogi commented Dec 16, 2020

I should find some time to complete this in the upcoming days.

@giraffate
Copy link
Contributor

ping from triage @kawogi. Could you have any update on this?

@ebroto
Copy link
Member

ebroto commented Jan 16, 2021

r? @flip1995 (I'm leaving the team, so I'm reassigning my PRs to other active members)

@rust-highfive rust-highfive assigned flip1995 and unassigned ebroto Jan 16, 2021
@giraffate
Copy link
Contributor

ping from triage @kawogi. According to triage procedure, I'm closing this because 2 weeks have passed with no activity. If you have more time to work on this, feel free to reopen this.

@giraffate giraffate closed this Jan 17, 2021
@giraffate giraffate added S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jan 17, 2021
@kawogi
Copy link
Author

kawogi commented Jan 17, 2021 •
edited
Loading

Sorry for the delay!
I added the requested test and would like update this pull request. How can this be re-opened or am I required to file another pull-request?

edit: re-opened as #6605

@kawogi kawogi mentioned this pull request Jan 17, 2021
Merged
@giraffate
Copy link
Contributor

Thanks for opening new PR!

bors added a commit that referenced this pull request Jan 21, 2021
@bors
Auto merge of #6605 - kawogi:doc-markdown, r=llogiq
4d381c3 
Doc markdown

I added "WebGL" along the lines of the existing "OpenGL" to the whitelist of `doc_markdown` as I found this to be a pretty common term.

(this is a follow-up of the now closed #6388)

changelog: Whitelist "WebGL" in `doc_markdown`.
@jonboh
Copy link
Contributor

jonboh commented Oct 10, 2023

@rustbot label -S-inactive-closed

@rustbot rustbot removed the S-inactive-closed Status: Closed due to inactivity label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebroto ebroto ebroto requested changes

Assignees

@flip1995 flip1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kawogi @rust-highfive @ebroto @giraffate @jonboh @flip1995 @rustbot