Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch Version/VersionReq usages to RustcVersion #6395

Merged
merged 6 commits into from
Dec 3, 2020
Merged

switch Version/VersionReq usages to RustcVersion #6395

merged 6 commits into from
Dec 3, 2020

Conversation

suyashb95
Copy link
Contributor

@suyashb95 suyashb95 commented Nov 28, 2020 •
edited
Loading

add rustc-semver to dependencies
switch Version/VersionReq usages to RustcVersion
changelog: none

@rust-highfive
Copy link

r? @ebroto

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 28, 2020
@suyashb95
Copy link
Contributor Author

r? @flip1995

@rust-highfive rust-highfive assigned flip1995 and unassigned ebroto Nov 28, 2020
@flip1995
Copy link
Member

@rust-lang/clippy This PR introduces a new dependency: rustc-semver. Because this crate was written by me, probably someone else should also take a look at this.

rustc-semver is a minimalistic crate, that lets you parse versions of the Rust compiler and compare them. The crate is a no_std library with 100% code coverage, checked with the new source-based-code-coverage.

@flip1995
Copy link
Member

rust-clippy/tests/ui/min_rust_version_multiple_inner_attr.rs

Line 3 in 428ce12

#![clippy::msrv = "=1.35.0"]

So the multiple inner attrs error has precedence over parsing errors.

oli-obk
oli-obk reviewed Nov 28, 2020
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me to switch to rustc-semver

clippy_lints/Cargo.toml Show resolved Hide resolved
@Manishearth
Copy link
Member

rustc-semver seems fine to me

@suyashb95
add rustc-semver to dependencies
cd087e5 
switch Version/VersionReq usages to RustcVersion
@suyashb95
fix msrv in test
4e4b831
flip1995
flip1995 requested changes Nov 29, 2020
View reviewed changes
clippy_lints/Cargo.toml Outdated Show resolved Hide resolved
clippy_lints/src/utils/mod.rs Outdated Show resolved Hide resolved
flip1995
flip1995 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on rustup

@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 30, 2020
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2020

📌 Commit e7258ac has been approved by flip1995

@bors
Copy link
Contributor

bors commented Nov 30, 2020

⌛ Testing commit e7258ac with merge e25d226...

bors added a commit that referenced this pull request Nov 30, 2020
@bors
Auto merge of #6395 - Suyash458:master, r=flip1995
e25d226 
switch Version/VersionReq usages to RustcVersion

add `rustc-semver` to dependencies
switch `Version/VersionReq` usages to `RustcVersion`
changelog: none
@bors
Copy link
Contributor

bors commented Nov 30, 2020

💔 Test failed - checks-action_test

@suyashb95
Copy link
Contributor Author

@flip1995 does this need a rebase?

@flip1995
Copy link
Member

flip1995 commented Dec 1, 2020

Nope, we're waiting for a rustup (which I already opened a PR for). The problem is that the rustup will need a ICE fix in rustc.

If a issue is labeled as S-waiting-on-rustup nothing more has to be done by the contributor.

@flip1995
Copy link
Member

flip1995 commented Dec 3, 2020

@bors retry rollup

@flip1995 flip1995 mentioned this pull request Dec 3, 2020
Merged
bors added a commit that referenced this pull request Dec 3, 2020
@bors
Auto merge of #6415 - flip1995:rollup-fz7872l, r=flip1995
249b6fe 
Rollup of 4 pull requests

Successful merges:

 - #6308 (add `internal-lints` feature to enable clippys internal lints (off by default))
 - #6395 (switch Version/VersionReq usages to RustcVersion )
 - #6402 (Add Collapsible match lint)
 - #6407 (CONTRIBUTING: update bors queue url from buildbot2.rlo to bors.rlo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

changelog: rollup
@bors bors merged commit b3d6d6e into rust-lang:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@suyashb95 @rust-highfive @flip1995 @Manishearth @bors @oli-obk @ebroto