Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone_double_ref: print reference type in lint message #6442

Merged
merged 1 commit into from
Dec 13, 2020

Conversation

matthiaskrgr
Copy link
Member

changelog: clone_double_ref: print the type of the reference in lint message

changelog: clone_double_ref: print the type of the reference in lint message
@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 12, 2020
@llogiq
Copy link
Contributor

llogiq commented Dec 13, 2020

This is a solid improvement. Perhaps we can make it even better by reducing the type output, but we can do this in a follow-up PR.

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 13, 2020

📌 Commit 0b145d6 has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Dec 13, 2020

⌛ Testing commit 0b145d6 with merge b7db5bf...

@bors
Copy link
Collaborator

bors commented Dec 13, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing b7db5bf to master...

@bors bors merged commit b7db5bf into rust-lang:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants