Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix derive and macro related false positives in field_reassign_with_default #6553

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

phansch
Copy link
Member

@phansch phansch commented Jan 5, 2021

Closes #6545

changelog: Fix derive and macro related false positives in [field_reassign_with_default]

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 5, 2021
@phansch phansch changed the title Fix derive and macro related false positives in [field_reassign_with_default] Fix derive and macro related false positives in field_reassign_with_default Jan 5, 2021
@phansch phansch force-pushed the field-reassign-with-default-macros branch 3 times, most recently from 8eb1d15 to 885abfe Compare January 5, 2021 19:30
@phansch phansch force-pushed the field-reassign-with-default-macros branch from 885abfe to 92f2bbb Compare January 5, 2021 19:31
@flip1995
Copy link
Member

flip1995 commented Jan 6, 2021

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jan 6, 2021

📌 Commit 92f2bbb has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jan 6, 2021

⌛ Testing commit 92f2bbb with merge efccfe8...

@bors
Copy link
Collaborator

bors commented Jan 6, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing efccfe8 to master...

@bors bors merged commit efccfe8 into rust-lang:master Jan 6, 2021
@phansch phansch deleted the field-reassign-with-default-macros branch January 6, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

field_reassign_with_default triggers in custom derives
4 participants