Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ICE 6539 #6582

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Fix the ICE 6539 #6582

merged 1 commit into from
Jan 17, 2021

Conversation

rail-rain
Copy link
Contributor

Fixes #6539

It happened because zero_sized_map_values used layout_of with types from type aliases, which is essentially the same as the ICE 4968.


changelog: Fix an ICE in zero_sized_map_values

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 12, 2021
It happened because `zero_sized_map_values` used `layout_of` with types
from type aliases, which is essentially the same as the ICE 4968.
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 17, 2021

📌 Commit feee45c has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jan 17, 2021

⌛ Testing commit feee45c with merge e0d331f...

@bors
Copy link
Contributor

bors commented Jan 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing e0d331f to master...

@bors bors merged commit e0d331f into rust-lang:master Jan 17, 2021
@rail-rain rail-rain deleted the ice_6539 branch January 17, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not fully normalize <T as Trait>::Assoc
4 participants