Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup #6647

Closed
wants to merge 24 commits into from
Closed

Rustup #6647

wants to merge 24 commits into from

Commits on Jan 15, 2021

  1. Configuration menu
    Copy the full SHA
    488153f View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Deprecate unknown_clippy_lints

    This is now handled by unknown_lints
    flip1995 committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    7449dc9 View commit details
    Browse the repository at this point in the history
  2. Remove PredicateKind::Atom

    jackh726 committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    38e293c View commit details
    Browse the repository at this point in the history
  3. Remove PredicateKind

    jackh726 committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    3436e21 View commit details
    Browse the repository at this point in the history
  4. Cleanup

    jackh726 committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    f06eeaf View commit details
    Browse the repository at this point in the history
  5. Use pred not binder

    jackh726 committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    7c3b6a6 View commit details
    Browse the repository at this point in the history
  6. Cleanup

    jackh726 committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    8256960 View commit details
    Browse the repository at this point in the history
  7. Review changes

    jackh726 committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    e73b8dc View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2021

  1. Auto merge of #80679 - jackh726:predicate-kind-take2, r=lcnr

    Remove PredicateKind and instead only use Binder<PredicateAtom>
    
    Originally brought up in rust-lang/rust#76814 (comment)
    
    r? `@lcnr`
    bors committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    e477105 View commit details
    Browse the repository at this point in the history
  2. Fix formatting for removed lints

    - Don't add backticks for the reason a lint was removed. This is almost
    never a code block, and when it is the backticks should be in the reason
    itself.
    - Don't assume clippy is the only tool that needs to be checked for
    backwards compatibility
    jyn514 committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    abb40c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Rollup merge of #81038 - flip1995:clippyup, r=Manishearth

    Update Clippy
    
    Biweekly Clippy update
    
    r? ``@Manishearth``
    KodrAus authored Jan 18, 2021
    Configuration menu
    Copy the full SHA
    9009f8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dce2262 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2454408 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Force token collection to run when parsing nonterminals

    Fixes #81007
    
    Previously, we would fail to collect tokens in the proper place when
    only builtin attributes were present. As a result, we would end up with
    attribute tokens in the collected `TokenStream`, leading to duplication
    when we attempted to prepend the attributes from the AST node.
    
    We now explicitly track when token collection must be performed due to
    nomterminal parsing.
    Aaron1011 committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    2be935d View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Add loop head span to hir

    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    612a7fc View commit details
    Browse the repository at this point in the history
  2. Fix clippy and comment

    estebank committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    3a5ede6 View commit details
    Browse the repository at this point in the history
  3. Auto merge of #81135 - jyn514:no-backticks, r=flip1995

    Fix formatting for removed lints
    
    - Don't add backticks for the reason a lint was removed. This is almost
    never a code block, and when it is the backticks should be in the reason
    itself.
    - Don't assume clippy is the only tool that needs to be checked for
    backwards compatibility
    
    I split this out of rust-lang/rust#80527 because it kept causing tests to fail, and it's a good change to have anyway.
    
    r? `@flip1995`
    bors committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    a1b89f0 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of #81236 - estebank:everybody-loop-now, r=oli-obk

    Gracefully handle loop labels missing leading `'` in different positions
    
    Fix #81192.
    
    * Account for labels when suggesting `loop` instead of `while true`
    * Suggest `'a` when given `a` only when appropriate
    * Add loop head span to hir
    * Tweak error for invalid `break expr`
    * Add more misspelled label tests
    * Avoid emitting redundant "unused label" lint
    * Parse loop labels missing a leading `'`
    
    Each commit can be reviewed in isolation.
    m-ou-se authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    e9b2cf4 View commit details
    Browse the repository at this point in the history
  5. Make more traits of the From/Into family diagnostic items

    Following traits are now diagnostic items:
    - `From` (unchanged)
    - `Into`
    - `TryFrom`
    - `TryInto`
    
    This also adds symbols for those items:
    - `into_trait`
    - `try_from_trait`
    - `try_into_trait`
    flip1995 committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    8c00304 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Rollup merge of #79951 - LeSeulArtichaut:ty-ir, r=nikomatsakis

    Refractor a few more types to `rustc_type_ir`
    
    In the continuation of #79169, ~~blocked on that PR~~.
    
    This PR:
     - moves `IntVarValue`, `FloatVarValue`, `InferTy` (and friends) and `Variance`
     - creates the `IntTy`, `UintTy` and `FloatTy` enums in `rustc_type_ir`, based on their `ast` and `chalk_ir` equilavents, and uses them for types in the rest of the compiler.
    
    ~~I will split up that commit to make this easier to review and to have a better commit history.~~
    EDIT: done, I split the PR in commits of 200-ish lines each
    
    r? `````@nikomatsakis````` cc `````@jackh726`````
    JohnTitor authored Jan 28, 2021
    Configuration menu
    Copy the full SHA
    7bd3d6c View commit details
    Browse the repository at this point in the history
  2. Rollup merge of #81277 - flip1995:from_diag_items, r=matthewjasper

    Make more traits of the From/Into family diagnostic items
    
    Following traits are now diagnostic items:
    - `From` (unchanged)
    - `Into`
    - `TryFrom`
    - `TryInto`
    
    This also adds symbols for those items:
    - `into_trait`
    - `try_from_trait`
    - `try_into_trait`
    
    Related: rust-lang#6620 (comment)
    JohnTitor authored Jan 28, 2021
    Configuration menu
    Copy the full SHA
    299ff49 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Rollup merge of #81176 - camsteffen:qpath-res, r=oli-obk

    Improve safety of `LateContext::qpath_res`
    
    This is my first rustc code change, inspired by hacking on clippy!
    
    The first change is to clear cached `TypeckResults` from `LateContext` when visiting a nested item. I took a hint from [here](https://github.com/rust-lang/rust/blob/5e91c4ecc09312d8b63d250a432b0f3ef83f1df7/compiler/rustc_privacy/src/lib.rs#L1300).
    
    Clippy has a `qpath_res` util function to avoid a possible ICE in `LateContext::qpath_res`. But the docs of `LateContext::qpath_res` promise no ICE. So this updates the `LateContext` method to keep its promises, and removes the util function.
    
    Related: rust-lang#4545
    
    CC ````````````@eddyb```````````` since you've done related work
    CC ````````````@flip1995```````````` FYI
    JohnTitor authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    c18d6f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7155b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de71f8e View commit details
    Browse the repository at this point in the history