lintcheck: support git sources #6686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
flip1995
approved these changes
Feb 6, 2021
clippy_dev/src/lintcheck.rs
Outdated
| if tk.versions.is_some() && (tk.git_url.is_some() || tk.git_hash.is_some()) | ||
| || tk.git_hash.is_some() != tk.git_url.is_some() | ||
| { | ||
| dbg!(&tk); |
There was a problem hiding this comment.
I would have added some kind of error eprintln that prints all these but imo the dbg macro already prints all the information that I would want in the case of an error.
clippy_dev/src/lintcheck.rs
Outdated
Comment on lines
168
to
170
| dbg!(error); | ||
| dbg!(&cargo_clippy_path); | ||
| dbg!(&self.path); |
There was a problem hiding this comment.
I don't think we should have dbg macros in our code.
|
@bors r=flip1995 |
|
📌 Commit 2bffbfc has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for git sources in
cargo dev-lintcheckYou can add a git source to
clippy_dev/lintcheck_crates.tomlby having agit_urland agit_hashkey instead of theversionsarray.The repo will the be cloned and checked out to the requested commit before checking it with clippy.
Fixes #6642
changelog: lintcheck: support git sources