Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade trivial_regex to nursery #6696

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Feb 8, 2021

See #6690. I think there is still value in a trivial_regex lint, but only if clippy can tell that the regex is only ever constructed and applied to a single input.

let regex = Regex::new("trivial_regex")?;
println!("{}", regex.is_match(s));
// `regex` never used again

changelog: remove trivial_regex from default set of enabled lints

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 8, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 8, 2021

📌 Commit fd35517 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Feb 8, 2021

⌛ Testing commit fd35517 with merge 4bbd7e4...

@bors
Copy link
Contributor

bors commented Feb 8, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 4bbd7e4 to master...

@bors bors merged commit 4bbd7e4 into rust-lang:master Feb 8, 2021
@dtolnay dtolnay deleted the regex branch March 27, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants