Add the from_str_radix_10 lint

[booleancoercion]

changelog: added the new from_str_radix_10 which sometimes replaces calls to primitive::from_str_radix to str::parse

This is ready to be merged, although maybe the category should be pedantic instead of style? I'm not sure where it fits better.

Closes #6713.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[llogiq]

I think style is OK, as I don't expect any false positives here.

[llogiq]

This is a good start. Just some suggestions to improve it even more, then I think we can unleash it on our users. 😄

[booleancoercion]

Thanks, @llogiq - if you could only take a final look, that'd be great.

[llogiq]

I'm a bit unclear about possible incorrectness of the suggestion. Otherwise this looks good and I'll r+ this once I understand it.

[booleancoercion]

Well, nevermind the possible incorrectness..

[booleancoercion]

Now it's really done, @llogiq. I didn't want to implement a workaround for #6767 since fixing that issue will fix this and other lints anyway, and it hardly changes anything. Definitely doesn't have to do with correctness in any case, so I don't think it's blocking.

[llogiq]

Thank you! @bors r+

[bors]

📌 Commit c4b8d87 has been approved by llogiq

[bors]

⌛ Testing commit c4b8d87 with merge 67087a1...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 67087a1 to master...