Inconsistent struct constructor #6769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Y-Nak
force-pushed
the
inconsistent-struct-constructor
branch
from
c706d74 to
4adea7d
Compare
Y-Nak
force-pushed
the
inconsistent-struct-constructor
branch
from
4adea7d to
d646aa2
Compare
matthiaskrgr
requested changes
Feb 21, 2021
Comment on lines
13
to
41
| /// **What it does:** Checks for struct constructors where the order of the field init | ||
| /// shorthand in the constructor is inconsistent with the order in the struct definition. | ||
| /// | ||
| /// **Why is this bad?** It decreases readability and consistency. | ||
| /// | ||
| /// **Known problems:** None. | ||
| /// | ||
| /// **Example:** | ||
| /// | ||
| /// ```rust | ||
| /// struct Foo { | ||
| /// x: i32, | ||
| /// y: i32, | ||
| /// } | ||
| /// let x = 1; | ||
| /// let y = 2; | ||
| /// Foo { y, x }; | ||
| /// ``` | ||
| /// | ||
| /// Use instead: | ||
| /// ```rust | ||
| /// # struct Foo { | ||
| /// # x: i32, | ||
| /// # y: i32, | ||
| /// # } | ||
| /// # let x = 1; | ||
| /// # let y = 2; | ||
| /// Foo { x, y }; | ||
| /// ``` |
There was a problem hiding this comment.
I wonder if we should add some kind of short demonstration that Foo {x, y} and Foo {y,x} are the same?
#[derive(Eq, PartialEq, Debug)]
struct Foo {x: i32, y: i32}
fn main() {
let x = 0;
let y = 1;
assert_eq!(Foo {x, y}, Foo {y, x});
}
Comment on lines
76
to
78
| } | ||
| fields_snippet.push_str(&format!("{}", last_ident)); | ||
|
|
There was a problem hiding this comment.
Hmm shouldn't this trigger clippy::useless_format...? 🤔
This can be just
fields_snippet.push_str(&last_ident.to_string());
| let base_snippet = if let Some(base) = base { | ||
| format!(", ..{}", snippet(cx, base.span, "..")) | ||
| } else { | ||
| "".to_string() |
matthiaskrgr
added
S-waiting-on-author
|
Changes:
|
matthiaskrgr
approved these changes
Feb 22, 2021
|
Thanks! |
|
📌 Commit bfdf0fa has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6352
r? @matthiaskrgr
I added the lint that checks for the struct constructors where the order of the field init shorthands is inconsistent with that in the struct definition.
changelog: Add style lint:
inconsistent_struct_constructor