Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positive in use_self #6833

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix false-positive in use_self #6833

merged 1 commit into from
Mar 4, 2021

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Mar 3, 2021

Fixes #6818.

changelog: Fix false positives for use_self in macros.

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 3, 2021
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach lgtm

@daxpedda daxpedda marked this pull request as ready for review March 4, 2021 07:43
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2021

📌 Commit 5656510 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Mar 4, 2021

⌛ Testing commit 5656510 with merge 6680710...

@bors
Copy link
Contributor

bors commented Mar 4, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 6680710 to master...

@bors bors merged commit 6680710 into rust-lang:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use_self is triggered inside derived code
4 participants