-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let Cargo track CLIPPY_ARGS #6834
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @phansch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
Thank you for the PR, the dogfood test changes look good to me! However, given our history with Maybe r? @flip1995 |
Local testing didn't lead to any obvious problems with this, so I'm happy to merge this. But we should revisit the placement of the @bors r=phansch,flip1995,oli-obk |
📌 Commit 3cd5f44 has been approved by |
Let Cargo track CLIPPY_ARGS This PR makes `clippy-driver` emit `CLIPPY_ARGS` in its `dep-info` output. Just like #6441, this allows this workflow to work: ```shell cargo clippy # warning: empty `loop {}` wastes CPU cycles cargo clippy -- -A clippy::empty_loop # no warnings emitted ``` But without rebuilding all dependencies. cc https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/CLIPPY_ARGS.20is.20not.20tracked.20by.20Cargo/near/228599088 Changelog: Cargo now re-runs Clippy if arguments after `--` provided to `cargo clippy` are changed.
💔 Test failed - checks-action_test |
@bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Should I open a https://github.com/rust-lang/rust issue for this? |
Yeah, I think that would be good 👍 |
This PR makes
clippy-driver
emitCLIPPY_ARGS
in itsdep-info
output.Just like #6441, this allows this workflow to work:
But without rebuilding all dependencies.
cc https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/CLIPPY_ARGS.20is.20not.20tracked.20by.20Cargo/near/228599088
changelog: Cargo now re-runs Clippy if arguments after
--
provided tocargo clippy
are changed.