Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update RA setup documentation #6888

Merged
merged 3 commits into from
Mar 17, 2021
Merged

docs: update RA setup documentation #6888

merged 3 commits into from
Mar 17, 2021

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Mar 12, 2021 •
edited
Loading

Add documentation how to get rust-analyzer to like clippys extern crate rustc deps.

Fixes #6883

This initially removed cargo-dev ra_setup but it is still needed by folks who use intellij rust, so keeping that.

changelog: none

@matthiaskrgr matthiaskrgr marked this pull request as draft March 12, 2021 00:31
matthiaskrgr
matthiaskrgr commented Mar 12, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@matthiaskrgr matthiaskrgr added A-documentation Area: Adding or improving documentation S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Mar 12, 2021
@matthiaskrgr matthiaskrgr changed the title remove clippy dev ra_setup, update RA setup documentation [BLOCKED] remove clippy dev ra_setup, update RA setup documentation Mar 12, 2021
@alex-700
Copy link
Contributor

@matthiaskrgr please, remember, that ra_setup was used not only for rust-analyzer, but also for intellij-rust plugin. I'm not sure, that intellij-rust can work without it for now. I had checked and it wasn't work properly without ra_setup (at least right out of the box).

@matthiaskrgr
Copy link
Member Author

Oh I did not consider that at all... 😅
Maybe we should just add some additional RA setup docs then.

@matthiaskrgr matthiaskrgr mentioned this pull request Mar 12, 2021
Closed
@matthiaskrgr matthiaskrgr changed the title [BLOCKED] remove clippy dev ra_setup, update RA setup documentation docs: update RA setup documentation Mar 16, 2021
@matthiaskrgr matthiaskrgr removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Mar 16, 2021
@matthiaskrgr
Copy link
Member Author

I can confirm that RA from rustc nightly finds rustc symbols now 🎉
PR should be ready to review.

@matthiaskrgr matthiaskrgr marked this pull request as ready for review March 16, 2021 11:34
flip1995
flip1995 reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we rename the command to ide_setup?

CONTRIBUTING.md Outdated Show resolved Hide resolved
@matthiaskrgr
Copy link
Member Author

Yeah ide_setup sounds better 👍; did the rename.

@matthiaskrgr matthiaskrgr added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 17, 2021
flip1995
flip1995 reviewed Mar 17, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Mar 17, 2021

📌 Commit 6546285 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Mar 17, 2021

⌛ Testing commit 6546285 with merge a2ee849...

@bors
Copy link
Contributor

bors commented Mar 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing a2ee849 to master...

@bors bors merged commit a2ee849 into rust-lang:master Mar 17, 2021
@bors bors mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees
No one assigned
Labels
A-documentation Area: Adding or improving documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove cargo dev ra_setup
4 participants
@matthiaskrgr @alex-700 @flip1995 @bors