-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix explicit_into_iter_loop
#6982
Conversation
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a small code-style NIT. r=me with that fixed.
ccf9bd2
to
ab3101a
Compare
@bors r+ Thanks! |
📌 Commit ab3101a has been approved by |
Fix `explicit_into_iter_loop` fixes: #6900 changelog: Only lint when `into_iter` is an implementation of `IntoIterator`
💥 Test timed out |
No idea what went wrong there. Spurious failure? |
Bors had some problems today. It seems to be up in running again we could at least merge some other PRs with a retry. So somebody just has to queue this PR again. I'll ask in the Clippy Zulip if a member could do that 🙃 |
I'm back from my easter slumber! 🐇 🥚 @bors retry |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #6931) made this pull request unmergeable. Please resolve the merge conflicts. |
Only lint when `into_iter` is an implementation of `IntoIterator` Minor cleanups
ab3101a
to
6b5778e
Compare
@bors r+ Now it should work. |
📌 Commit 6b5778e has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes: #6900
changelog: Only lint when
into_iter
is an implementation ofIntoIterator