Improve clone_on_copy
#7000
Merged
Improve clone_on_copy
#7000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thank you! @bors r+ |
|
📌 Commit db5bd9f has been approved by |
bors
added a commit
that referenced
this pull request
Mar 29, 2021
Improve `clone_on_copy` This also removes the `clone_on_copy_mut` test as the same thing is covered in the `clone_on_copy` test. changelog: `copy_on_clone` lint on chained method calls taking self by value changelog: `copy_on_clone` only lint when using the `Clone` trait changelog: `copy_on_clone` correct suggestion when the cloned value is a macro call.
|
💔 Test failed - checks-action_test |
Lint on `_.clone().method()` when method takes self by value Set applicability correctly Correct suggestion when the cloned value is a macro call. e.g. `m!(x).clone()` Don't lint when not using the `Clone` trait
Jarcho
force-pushed
the
clone_on_copy_fp
branch
from
db5bd9f to
d265776
Compare
|
@bors r+ |
|
📌 Commit d265776 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the
clone_on_copy_muttest as the same thing is covered in theclone_on_copytest.changelog:
copy_on_clonelint on chained method calls taking self by valuechangelog:
copy_on_cloneonly lint when using theClonetraitchangelog:
copy_on_clonecorrect suggestion when the cloned value is a macro call.