Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manual_map at the end of an if chain #7004

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Fix manual_map at the end of an if chain #7004

merged 1 commit into from
Mar 30, 2021

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Mar 30, 2021

changelog: Fix manual_map suggestion at the end of an if chain

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 30, 2021
camsteffen
camsteffen suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One nit.

clippy_utils/src/lib.rs Outdated Show resolved Hide resolved
@Jarcho Jarcho force-pushed the manual_map_if_then_else branch from 7257944 to 46209c5 Compare March 30, 2021 12:39
@Jarcho Jarcho force-pushed the manual_map_if_then_else branch from 46209c5 to fa689f8 Compare March 30, 2021 13:58
@camsteffen
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2021

📌 Commit fa689f8 has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Mar 30, 2021

⌛ Testing commit fa689f8 with merge 44bf60f...

@bors
Copy link
Contributor

bors commented Mar 30, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing 44bf60f to master...

@bors bors merged commit 44bf60f into rust-lang:master Mar 30, 2021
@bors bors mentioned this pull request Mar 30, 2021
Merged
@Jarcho Jarcho deleted the manual_map_if_then_else branch April 6, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsteffen camsteffen camsteffen requested changes

Assignees

@camsteffen camsteffen

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jarcho @rust-highfive @camsteffen @bors